Skip to content

[Documentation] Refactor: React guides #5375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2024
Merged

[Documentation] Refactor: React guides #5375

merged 1 commit into from
Nov 21, 2024

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Nov 10, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on updating documentation, component descriptions, and correcting parameter names across various files in the thirdweb package. It also introduces new content related to social identities, ecosystem wallets, and account abstraction features.

Detailed summary

  • Changed example code blocks from ts to tsx.
  • Updated component documentation to reflect @wallet instead of @account.
  • Fixed parameter names from phonNumber to phoneNumber.
  • Added new content for social identities and ecosystem wallet usage.
  • Enhanced descriptions for components and hooks.
  • Introduced live playground links for testing features.
  • Updated PayEmbed documentation for clarity on usage and options.
  • Added detailed guides on sponsored transactions and account abstraction.

The following files were skipped due to too many changes: apps/portal/src/app/react/v5/in-app-wallet/get-started/page.mdx, apps/portal/src/app/react/v5/sidebar.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 9:01pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 9:01pm
thirdweb-www ❌ Failed (Inspect) Jan 9, 2025 9:01pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 9:01pm

@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: e8e7e51

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Nov 10, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges mentioned this pull request Nov 10, 2024
Merged
@github-actions github-actions bot added Portal Involves changes to the Portal (docs) codebase. packages labels Nov 10, 2024
@joaquim-verges joaquim-verges marked this pull request as ready for review November 10, 2024 09:52
@joaquim-verges joaquim-verges added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Nov 10, 2024 — with Graphite App
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.97 KB (0%) 900 ms (0%) 501 ms (-5.22% 🔽) 1.4 s
thirdweb (cjs) 105.01 KB (0%) 2.2 s (0%) 862 ms (+60.69% 🔺) 3 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 97 ms (+382.62% 🔺) 209 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 19 ms (+363.73% 🔺) 29 ms
thirdweb/react (minimal + tree-shaking) 18.38 KB (0%) 368 ms (0%) 110 ms (+18.17% 🔺) 478 ms

@joaquim-verges joaquim-verges force-pushed the 11-10-update_tsdoc_references branch from 7433ee2 to 3358248 Compare November 10, 2024 15:43
@joaquim-verges joaquim-verges force-pushed the 11-10-refactor_react_guides_in_portal branch 2 times, most recently from 5aa67ce to cddf364 Compare November 10, 2024 15:48
@codecov
Copy link

codecov bot commented Nov 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.88%. Comparing base (7973d64) to head (e8e7e51).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5375   +/-   ##
=======================================
  Coverage   43.88%   43.88%           
=======================================
  Files        1075     1075           
  Lines       55944    55944           
  Branches     3910     3909    -1     
=======================================
  Hits        24550    24550           
  Misses      30711    30711           
  Partials      683      683
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 7973d64
packages 38.61% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...hirdweb/src/react/core/social/useSocialProfiles.ts 11.11% <ø> (ø)
packages/thirdweb/src/react/web/ui/PayEmbed.tsx 39.50% <ø> (ø)
...dweb/src/react/web/ui/prebuilt/Account/address.tsx 100.00% <ø> (ø)
...rdweb/src/react/web/ui/prebuilt/Account/avatar.tsx 50.00% <ø> (ø)
...dweb/src/react/web/ui/prebuilt/Account/balance.tsx 80.00% <ø> (ø)
...dweb/src/react/web/ui/prebuilt/Account/blobbie.tsx 40.00% <ø> (ø)
...hirdweb/src/react/web/ui/prebuilt/Account/name.tsx 67.44% <ø> (ø)
...web/src/react/web/ui/prebuilt/Account/provider.tsx 75.00% <ø> (ø)
...es/thirdweb/src/react/web/ui/prebuilt/NFT/name.tsx 71.42% <ø> (ø)
---- 🚨 Try these New Features:

@joaquim-verges joaquim-verges force-pushed the 11-10-refactor_react_guides_in_portal branch from cddf364 to 7808d12 Compare November 10, 2024 17:10
@joaquim-verges joaquim-verges force-pushed the 11-10-refactor_react_guides_in_portal branch from bc9a38e to 6301fa0 Compare November 20, 2024 08:05
@joaquim-verges joaquim-verges force-pushed the 11-10-refactor_react_guides_in_portal branch from 6301fa0 to 0820e61 Compare November 20, 2024 09:37
@joaquim-verges joaquim-verges force-pushed the 11-10-refactor_react_guides_in_portal branch from 0820e61 to 49c1ebb Compare November 20, 2024 10:56
@joaquim-verges joaquim-verges force-pushed the 11-10-refactor_react_guides_in_portal branch from 49c1ebb to c154d4d Compare November 20, 2024 12:04
@joaquim-verges joaquim-verges force-pushed the 11-10-refactor_react_guides_in_portal branch from c154d4d to e8e7e51 Compare November 21, 2024 02:02
@joaquim-verges joaquim-verges merged commit 17488b8 into main Nov 21, 2024
32 checks passed
@joaquim-verges joaquim-verges deleted the 11-10-refactor_react_guides_in_portal branch November 21, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@gregfromstl gregfromstl Awaiting requested review from gregfromstl

@jnsdls jnsdls Awaiting requested review from jnsdls

@MananTank MananTank Awaiting requested review from MananTank

@edwardysun edwardysun Awaiting requested review from edwardysun

+1 more reviewer

@ElasticBottle ElasticBottle ElasticBottle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@joaquim-verges joaquim-verges

Labels

DO NOT MERGE This pull request is still in progress and is not ready to be merged. packages Portal Involves changes to the Portal (docs) codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joaquim-verges @ElasticBottle @gregfromstl